-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove exception to status legacy code from http codec #15773
remove exception to status legacy code from http codec #15773
Conversation
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you for the cleanup.
BTW Got worried in case there were random other EnvoyExceptions floating through some helper methods in the dispatch callstack, but just saw they would have been uncaught and we would have seen them.
Thank you!
/retest |
Retrying Azure Pipelines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks. Can we remove innerDispatch()
also as I don't think it's needed anymore?
/wait
Sure, that sounds reasonable. |
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Thanks for catching that Matt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Signed-off-by: chaoqin-li1123 chaoqinli@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: exceptionToStatus is used in the migration from C++ exception to error status in http codec. since the exception is no longer used, remove the exception and the exceptionToStatus utility function from the codebase. This is also part of the effort to remove exception from data plane. (#14320)
Additional Description:
Risk Level:low
Testing:none
Docs Changes:none
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]